[18.8] Move FillEventHeader from FRM to FairRun #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuhlig1
requested changes
Nov 10, 2022
3 tasks
karabowi
previously approved these changes
Nov 14, 2022
22fa1f0 to
2293959
Compare
fuhlig1
previously approved these changes
Nov 15, 2022
|
@karabowi should we backport this to 18.8, when it's merged to dev? Thinking again: If we decide to add it to 18.8. I would already put the Changelog-Entry in the 18.8 section. |
|
I would propose to port it back. |
FairRootManager::FillEventHeader is only called from FairRun (and derived classes). So create an appropriate FairRun::FillEventHeader and use it around. Deprecate FairRootManager::FillEventHeader.
2293959 to
e6e5c8f
Compare
Okay.
|
3 tasks
fuhlig1
reviewed
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FairRootManager::FillEventHeader()is only called from FairRun (and derived classes). So create an appropriateFairRun::FillEventHeader()and use it around.Deprecate
FairRootManager::FillEventHeader().Checklist:
devbranch