topotests: improve embedded RP test reliability #19240
Conversation
|
Thank you @rzalamena . Mr. Bot has some style suggestions, otherwise it looks good. |
|
yes, thanks for turning this around, Rafael - but ... could you rebase instead of adding a "fix things" commit? |
|
Applied the style changes as a separated commit, because it touches much more places than what I intended for the fixes. |
what do you mean by rebase? I'm already applying the changes on top of |
I mean rebase and fixup or squash the trivial/fix changes into a meaningful commit - we're trying to keep the commit series meaningful |
Two changes: - Check the embedded RP groups one by one increment instead of starting all groups and checking them later (they might get learned in different order). - Increase the amount of wait time for validating the existence of multicast states. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Apply style changes to embedded RP topotest. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
|
Squashed the two fix commits into one. |
|
@Mergifyio backport stable/10.4 |
✅ Backports have been created
|
topotests: improve embedded RP test reliability (backport #19240)
Bug Fixes: * bgpd: initialize local variable (backport #19233) * ospfd: Use after free cleanup of lsa (backport #19224) * vtysh: copy config from file should actually apply (backport #19242) * Revert PR #18358: BGP evpn testing and bug fixes related to non default EVPN backbone (backport #19241) * topotests: improve embedded RP test reliability (backport #19240) * lib, zebra: mark singleton nexthops inactive/active on link state changes for wecmp (backport #18947) * bgpd: LL next-hop capabilty fixes (backport #19261) * eigrp: validate hello packets and tlvs better (backport #19251) * bgpd: Fix compilation error in bgpd module: Update TP_ARGS for bgp (backport #19266) * bgpd: Ensure addpath does not withdraw selected route in some situations (backport #19210) * bgpd: [GR] fixed selectionDeferralTimer to display select_defer_time val by #19282 * bgpd: LL next-hop capabilty fixes (round 2) (backport #19277) * lib: compute link-state zapi message size (backport #19290) * zebra: Fix buffer overflows found by fuzzing. (backport #19303) Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
Two changes in Embedded RP topology test: