bgpd: Fix incorrect stripping of transitive extended communities due … (backport #19065) #19095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bad type match The ecommunity_non_transitive() helper incorrectly used CHECK_FLAG() to test against ECOMMUNITY_ENCODE_IP_NON_TRANS (0x41), which is a full type code, not a bitmask. As a result, type 0x03 (transitive opaque), used for encapsulation (e.g., VXLAN), was mistakenly matched and stripped during re-announcement. This patch replaces the incorrect CHECK_FLAG() with a direct equality check. Bug caused stripping of valid VXLAN encapsulation communities (type 0x03) on reflected UPDATEs. Signed-off-by: Nick Bouliane <nbouliane@coreweave.com> (cherry picked from commit 954e662) # Conflicts: # bgpd/bgp_ecommunity.c
|
Cherry-pick of 954e662 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to bad type match
The ecommunity_non_transitive() helper incorrectly used CHECK_FLAG() to test against ECOMMUNITY_ENCODE_IP_NON_TRANS (0x41), which is a full type code, not a bitmask. As a result, type 0x03 (transitive opaque), used for encapsulation (e.g., VXLAN), was mistakenly matched and stripped during re-announcement.
This patch replaces the incorrect CHECK_FLAG() with a direct equality check.
Bug caused stripping of valid VXLAN encapsulation communities (type 0x03) on reflected UPDATEs.
Signed-off-by: Nick Bouliane nbouliane@coreweave.com
That should fix the bug mentioned here: https://blog.ipspace.net/2025/06/evpn-route-attributes-matter/
This is an automatic backport of pull request #19065 done by Mergify.