bgpd: Fix incorrect stripping of transitive extended communities due … #19065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the same update to an equality check needed for |
This one is an actual flag representing the transitive bit and not a type. From rfc4360: |
|
please fix the signed off by in the description and commit ... :-) |
…to bad type match The ecommunity_non_transitive() helper incorrectly used CHECK_FLAG() to test against ECOMMUNITY_ENCODE_IP_NON_TRANS (0x41), which is a full type code, not a bitmask. As a result, type 0x03 (transitive opaque), used for encapsulation (e.g., VXLAN), was mistakenly matched and stripped during re-announcement. This patch replaces the incorrect CHECK_FLAG() with a direct equality check. Bug caused stripping of valid VXLAN encapsulation communities (type 0x03) on reflected UPDATEs. Signed-off-by: Nick Bouliane <nbouliane@coreweave.com>
done ! thank you :) |
|
@Mergifyio backport dev/10.4 stable/10.3 stable/10.2 stable/10.1 |
✅ Backports have been created
|
This was referenced Jun 26, 2025
Merged
Merged
Closed
Jafaral
added a commit
that referenced
this pull request
Jun 26, 2025
bgpd: Fix incorrect stripping of transitive extended communities due … (backport #19065)
Jafaral
added a commit
that referenced
this pull request
Jun 27, 2025
bgpd: Fix incorrect stripping of transitive extended communities due … (backport #19065)
ton31337
added a commit
to opensourcerouting/frr
that referenced
this pull request
Aug 2, 2025
* bgpd: correct no form commands (backport FRRouting#18911) * bgpd: fix to show exist/non-exist-map in 'show run' properly FRRouting#18853 * redhat: make FRR RPM build to work on RedHat 10 (backport FRRouting#18920) * build: check for libunwind.h, not unwind.h (backport FRRouting#18912) * bgpd: use AS4B format for BGP loc-rib messages. (backport FRRouting#18936) * bgpd: fix for the validity and the presence of prefixes in the BGP VPN table. (backport FRRouting#17370) * bgpd: Force adj-rib-out updates if MRAI is kicked in (backport FRRouting#18959) * zebra: Provide SID value when sending SRv6 SID release notify message (backport FRRouting#18971) * bgpd: Fix crash when fetching statistics for bgp instance (backport FRRouting#19003) * nhrpd: fix crash when accessing invalid memory zone (backport FRRouting#18994) * zebra: Initialize RB tree for router tables (backport FRRouting#19049) * zebra: fix null pointer dereference in zebra_evpn_sync_neigh_del (backport FRRouting#19054) * zebra: fix stale NHG in kernel (backport FRRouting#18899) * bgpd: Fix incorrect stripping of transitive extended communities (backport FRRouting#19065) * lib: Fix no on-match goto NUM command (backport FRRouting#19108) * bgpd: Fix extended community check for IP non-transitive type (backport FRRouting#19097) * bgpd: Fix DEREF_OF_NULL.EX.COND in bgp_updgrp_packet (backport FRRouting#19126) * lib: revert addition of vtysh_flush() call in vty_out() (backport FRRouting#19109) * bgpd: Extract link bandwidth value from extcommunity before using for WCMP (backport FRRouting#19165) * Use ipv4 class E addresses (240.0.0.0/4) as connected routes by default (backport FRRouting#18095) * bfdd: Set bfd.LocalDiag when transitioning to AdminDown (backport FRRouting#18592) * zebra: clean up a json object leak (backport FRRouting#19192) * bgpd: Do not try to reuse freed route-maps (backport FRRouting#19191) * lib: fix routemap crash (backport FRRouting#19127) * bgpd: initialize local variable (backport FRRouting#19233) * ospfd: Use after free cleanup of lsa (backport FRRouting#19224) * vtysh: copy config from file should actually apply (backport FRRouting#19242) * bgpd : Fix compilation error in bgpd module: Update TP_ARGS for bgp (backport FRRouting#19266) * bgpd: Ensure addpath does not withdraw selected route in some situations (backport FRRouting#19210) * lib, zebra: mark singleton nexthops inactive/active on link state changes for wecmp (backport FRRouting#18947) * eigrp: validate hello packets and tlvs better (backport FRRouting#19251) * bgpd: [GR] fixed selectionDeferralTimer to display select_defer_time val FRRouting#19283 Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to bad type match
The ecommunity_non_transitive() helper incorrectly used CHECK_FLAG() to test against ECOMMUNITY_ENCODE_IP_NON_TRANS (0x41), which is a full type code, not a bitmask. As a result, type 0x03 (transitive opaque), used for encapsulation (e.g., VXLAN), was mistakenly matched and stripped during re-announcement.
This patch replaces the incorrect CHECK_FLAG() with a direct equality check.
Bug caused stripping of valid VXLAN encapsulation communities (type 0x03) on reflected UPDATEs.
Signed-off-by: Nick Bouliane nbouliane@coreweave.com
That should fix the bug mentioned here: https://blog.ipspace.net/2025/06/evpn-route-attributes-matter/