build: check for libunwind.h, not unwind.h (backport #18912) #18939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For extra confusion, unwind.h is also provided by the various libunwind implementations, but it provides a different API. And in some cases, they ship unwind.h but not libunwind.h, and then this check incorrectly detects as positive... This is a separate commit because it should probably be backported. (A larger rework of the backtrace configure option is following.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org> (cherry picked from commit 5adbfa7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For extra confusion, unwind.h is also provided by the various libunwind implementations, but it provides a different API. And in some cases, they ship unwind.h but not libunwind.h, and then this check incorrectly detects as positive...
This is a separate commit because it should probably be backported. (A larger rework of the backtrace configure option is following.)
This is an automatic backport of pull request #18912 done by Mergify.