bgpd: fix show bgp vpn rd json #18802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that "show bgp vpn rd RD json" output is correct. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
"show bgp vpn rd RD json" returns in invalid JSON unless RD is the last
route-distinguisher in the table. A trailing "," is present.
> r1# sh bgp ipv4 vpn rd 102:1 json
> {
> "vrfId": 0,
> "vrfName": "default",
> "tableVersion": 2,
> "routerId": "192.0.2.1",
> "defaultLocPrf": 100,
> "localAS": 65001,
> "routes": { "routeDistinguishers" : { "102:1" : { "2.2.2.2/32": [{"valid":true,"bestpath":true,"selectionReason":"First path received","pathFrom":"external","prefix":"2.2.2.2","prefixLen":32,"network":"2.2.2.2/32","version":1,"metric":0,"weight":0,"peerId":"192.0.2.2","path":"65002","origin":"incomplete","nexthops":[{"ip":"192.0.2.2","hostname":"r2","afi":"ipv4","used":true}]
> }]
> ,"192.0.2.2/32": [{"pathFrom":"external","prefix":"192.0.2.2","prefixLen":32,"network":"192.0.2.2/32","version":0,"metric":0,"weight":0,"peerId":"192.0.2.2","path":"65002","origin":"incomple
> te","nexthops":[{"ip":"192.0.2.2","hostname":"r2","afi":"ipv4","used":true}]}]
> ,"192.0.2.8/32": [{"valid":true,"bestpath":true,"selectionReason":"First path received","pathFrom":"external","prefix":"192.0.2.8","prefixLen":32,"network":"192.0.2.8/32","version":2,"metric
> ":0,"weight":0,"peerId":"192.0.2.2","path":"65002","origin":"incomplete","nexthops":[{"ip":"192.0.2.2","hostname":"r2","afi":"ipv4","used":true}]}]
> }, r1#
When there is another rd, "next" is set although it refers to another rd
that won't be displayed. And "next" is used to set the "is_last"
variable of bgp_show_table() that instructs whether to add a trailing ","
Do not set next if there no more rd to display.
Fixes: 1ae44df ("bgpd: unify 'show bgp' with RD with normal unicast bgp show")
Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
ci:rerun |
|
@Mergifyio backport stable/10.3 stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
This was referenced May 14, 2025
donaldsharp
added a commit
that referenced
this pull request
May 14, 2025
bgpd: fix show bgp vpn rd json (backport #18802)
donaldsharp
added a commit
that referenced
this pull request
May 14, 2025
bgpd: fix show bgp vpn rd json (backport #18802)
donaldsharp
added a commit
that referenced
this pull request
May 14, 2025
bgpd: fix show bgp vpn rd json (backport #18802)
donaldsharp
added a commit
that referenced
this pull request
May 14, 2025
bgpd: fix show bgp vpn rd json (backport #18802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"show bgp vpn rd RD json" returns in invalid JSON unless RD is the last
route-distinguisher in the table. A trailing "," is present.
When there is another rd, "next" is set although it refers to another rd
that won't be displayed. And "next" is used to set the "is_last"
variable of bgp_show_table() that instructs whether to add a trailing ","
Do not set next if there no more rd to display.
Fixes: 1ae44df ("bgpd: unify 'show bgp' with RD with normal unicast bgp show")
Signed-off-by: Maxime Gouin maxime.gouin@6wind.com
Signed-off-by: Louis Scalbert louis.scalbert@6wind.com