topotests: clarify bgp evpn rt5 #18708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chdxD1 please review this |
It is not used at all. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
for clarity. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
for clarity Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
They are not used. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Cosmetic change for clarity Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
They are always there. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Re-address Route-Distinguisher and route-targets for clarity. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
No need to prefix with the router name. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Reformat configuration commands in human readable style. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
in order to identify which router we are talking about. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
0d5bd46 commit was supposed to check that route-map "match evpn vni" was working by adding a r3 router that injected prefixes with VNI 102. A route-map on r1 was filtering r3 prefixes. However, the test was working even after removing r3. A check was needed without the route-map to check that r3 prefixes were received before applying the filter. Test "match evpn vni" route-map filtering applied to r2 input instead. Fixes: 0d5bd46 ("topotests: bgp_evpn_rt5, add test with match evpn vni command") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
b9aa7dc to
b7ffa50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic changes to bgp_evpn_rt5 topotest to prepare adding checks:
See individual commits.