watchfrr: Allow -w option to be ignored #18127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
|
I believe the format warnings are wrong and should be ignored |
eqvinox
requested changes
Feb 12, 2025
watchfrr is currently being started with $frr_global_options This is problematic as that it has a entirely different cli than the rest of the daemons and we have no plans to make this equivalent. Fixes: FRRouting#18107 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
f94bb23 to
9101bff
Compare
|
I rewrote it the way that @eqvinox has suggested and tested it. Works. |
eqvinox
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our startup scripts allow the passing of a cli command to all daemons started. Recently -w was added to handle namespaces better, but watchfrr was not included. This caused people using startup scripts to be a bit unhappy. Let's get them rolling by adding a quick and dirty ignoring of that flag to watchfrr.
Fixes: #18107