tests: Fix intermittent failures in srv6_encap_src_addr topotest
#18187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `srv6_encap_src_addr` does not use bgp. As such, it should not have bgpd marker. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
The `srv6_encap_src_addr` topotest tries to load sharpd.conf file that does not exist, which produces the following warning: ``` 2025-02-16 09:23:35,151 WARNING: topo: missing config 'r1' for '/media/frr/tests/topotests/srv6_encap_src_addr/r1/sharpd.conf' creating empty file '/etc/frr/sharpd.conf' ``` Since this topotest doesn't actually use sharpd, there's no point in loading the config file. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
The `srv6_encap_src_addr` topotest tries to load bgpd.conf file that does not exist, which produces the following warning: ``` 2025-02-16 09:23:35,151 WARNING: topo: missing config 'r1' for '/media/frr/tests/topotests/srv6_encap_src_addr/r1/bgpd.conf' creating empty file '/etc/frr/bgpd.conf' ``` Since this topotest doesn't actually use bgpd, there's no point in loading the config file. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
The `srv6_encap_src_addr` topotest uses a waiting time that is too small. For this reason during startup it prints a warning: ``` 2025-02-16 09:23:47,704 WARNING: topo: Waiting time is too small (count=10, wait=1), using default values (count=20, wait=3) ``` This commit increases the waiting time to fix the warning. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
srv6_encap_src_addr topotest
srv6_encap_src_addr topotestsrv6_encap_src_addr topotest
srv6_encap_src_addr topotestsrv6_encap_src_addr topotest
The `srv6_encap_src_addr` runs a vtysh command to configure the SRv6 encapsulation source address and then immediately invokes an iproute2 command to verify that zebra has set this address in the kernel. There is no wait between the two operations and the verification is attempted only once. If the topotest does not find the expected address it fails immediately. The problem is that when topotest is run on a heavyily loaded system, it can take some time for zebra to set the address in the kernel. In this case, when the topotest checks the kernel address right after running the vtysh command, it doesn't find the expected address because zebra hasn't set it yet. This commit gives zebra some time to configure the address. It keeps to check that the address is the expected one for about 1 minute. If after 1 minute the address is not the expected one then the test fails. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
21fedd9 to
c621b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
srv6_encap_src_addrruns a vtysh command to configure the SRv6 encapsulation source address and then immediately invokes an iproute2 command to verify that zebra has set this address in the kernel. There is no wait between the two operations and the verification is attempted only once. If the topotest does not find the expected address it fails immediately.The problem is that when topotest is run on a heavyily loaded system, it can take some time for zebra to set the address in the kernel.
In this case, when the topotest checks the kernel address right after running the vtysh command, it doesn't find the expected address because zebra hasn't set it yet.
This commit gives zebra some time to configure the address. It keeps to check that the address is the expected one for about 1 minute. If after 1 minute the address is not the expected one then the test fails.