lib: fix false context information for SRv6 route #18023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport dev/10.3 stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
The seg6local route dumped by 'show ipv6 route' makes think that the USP flavor is supported, whereas it is not the case. This information is a context information, and for End, the context information should be empty. > # show ipv6 route > [..] > I>* fc00:0:4::/128 [115/0] is directly connected, sr0, seg6local End USP, weight 1, 00:49:01 Fix this by suppressing the USP information from the output. Fixes: e496b42 ("bgpd: prefix-sid srv6 l3vpn service tlv") Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
340bf2d to
658bf02
Compare
This was referenced Feb 13, 2025
Jafaral
added a commit
that referenced
this pull request
Feb 14, 2025
lib: fix false context information for SRv6 route (backport #18023)
Jafaral
added a commit
that referenced
this pull request
Feb 14, 2025
lib: fix false context information for SRv6 route (backport #18023)
This was referenced Feb 14, 2025
donaldsharp
added a commit
that referenced
this pull request
Feb 15, 2025
…p_for_10.0 lib: fix false context information for SRv6 route (backport #18023 for 10.0)
donaldsharp
added a commit
that referenced
this pull request
Feb 15, 2025
…p_for_10.1 lib: fix false context information for SRv6 route (backport #18023 for 10.1)
cscarpitta
added a commit
to cscarpitta/frr
that referenced
this pull request
Mar 5, 2025
The function `srv6_sid_ctx2str` dumps the context information associated with a SID. For End SIDs, the context information dumped by this function is incorrect. It should be empty. This has been fixed in a couple of places in this PR: FRRouting#18023. The `srv6_sid_ctx2str` function is still dumping the wrong information. This commit fixes `srv6_sid_ctx2str`. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
cscarpitta
added a commit
to cscarpitta/frr
that referenced
this pull request
Mar 5, 2025
The output of `show ipv6 route` was dumping incorrect information for End SIDs. The issue has been fixed in this PR: FRRouting#18023 However, the sharpd documentation is still showing the wrong information. This PR fixes the issue by updating the documentation. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seg6local route dumped by 'show ipv6 route' makes think that the USP flavor is supported, whereas it is not the case. This information is a context information, and for End, the context information should be empty.
Fix this by suppressing the USP information from the output.
Fixes: e496b42 ("bgpd: prefix-sid srv6 l3vpn service tlv")