Skip to content

bgpd: Send non-transitive extended communities from/to OAD peers (backport #17896) #18010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bgpd: Send non-transitive extended communities from/to OAD peers (backport #17896) #18010

wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 4, 2025

This is an automatic backport of pull request #17896 done by [Mergify](https://mergify.com).

@ton31337 @mergify
bgpd: Send non-transitive extended communities from/to OAD peers
f5ba362 
draft-uttaro-idr-bgp-oad says:

Extended communities which are non-transitive across an AS boundary MAY be
advertised over an EBGP-OAD session if allowed by explicit policy configuration.
If allowed, all the members of the OAD SHOULD be configured to use the same
criteria.
For example, the Origin Validation State Extended Community, defined as
non-transitive in [RFC8097], can be advertised to peers in the same OAD.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit f2759c4)

# Conflicts:
#	bgpd/bgp_route.c
@ton31337 @mergify
tests: Check if OAD peers can exchange non-transitive extended commun…
5925054 
…ities

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit de90b70)
@mergify mergify bot added the conflicts label Feb 4, 2025
@mergify Mergify
Copy link
Author

mergify bot commented Feb 4, 2025

Cherry-pick of f2759c4 has failed:

On branch mergify/bp/stable/10.2/pr-17896
Your branch is up to date with 'origin/stable/10.2'.

You are currently cherry-picking commit f2759c46c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bgpd/bgp_route.c

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@frrbot frrbot bot added bgp tests Topotests, make check, etc labels Feb 4, 2025
@mergify mergify bot mentioned this pull request Feb 4, 2025
Merged
@ton31337 ton31337 closed this Feb 4, 2025
@ton31337 ton31337 deleted the mergify/bp/stable/10.2/pr-17896 branch February 4, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bgp size/M stable/10.2 tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ton31337