lib (+bfd): improve late timer warnings #18094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the "timer getting executed too late" warning: - warning threshold is now adjustable - check is performed when event actually executes, rather than when it's thrown on ready list - ignore_late_timer replaced with threshold = 0 - system load averages printed in log message - warning ratelimited to once per 10s rather than once per poll() Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
FRR's event loop prints a warning if a timer is executed more than some given threshold late, default being 4s. Set a more appropriate threshold for BFD TX timers (half TX interval). Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Make it consistent and call it `event` when formatting something to display. Much less confusing for some user seeing it too, since threads aren't involved. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
donaldsharp
reviewed
Feb 11, 2025
| @@ -107,6 +107,7 @@ void sbfd_init_xmttimer_update(struct bfd_session *bs, uint64_t jitter) | |||
| tv_normalize(&tv); | |||
|
|
|||
| event_add_timer_tv(master, sbfd_init_xmt_cb, bs, &tv, &bs->xmttimer_ev); | |||
| event_set_tardy_threshold(bs->xmttimer_ev, bs->xmt_TO / 2); | |||
There was a problem hiding this comment.
Is this better as a --enable-dev-build type thing? I'm afraid that a bunch of people will start complaining about this. We already get a fair number of starvation questions. This is probably going to raise the bar on that.
There was a problem hiding this comment.
Discussed on call, I think the consensus is that it should stay and users need to see it
There was a problem hiding this comment.
We could add something like please buy a faster CPU to the log message 😆
(though to be fair the CPU might be super fast and the system is just overloaded…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the "timer getting executed too late" warning:
use it for BFD TX timers (sets the threshold to half TX interval)
freebie
thread→eventin user-visible formattingAmong other things this is intended to distinguish BFD failures in CI due to high system load. Doesn't fix the issue but at least makes clear what is going on.
Example warning now looks like this:
(System load average is the thing printed in
uptime. The%pTHDoutput is a bit lengthy, but better to have that info.)