bgpd: Some fixes/improvements for Link-Local Next Hop capability #18080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icitly Fixes: db853cc ("bgpd: Implement Link-Local Next Hop capability") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
…citly Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
…eering This capability is enabled by default. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
We should involve checking received (not only advertised) capability, because otherwise we put both peers (one with LL capability, another without) into a single update-group and send 16-bytes NH instead of 16-bytes and 32-bytes separately. Fixes: db853cc ("bgpd: Implement Link-Local Next Hop capability") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
riw777
approved these changes
Feb 10, 2025
If we have LL Next Hop capability exchanged, we should send LL-only as 16-bytes NH instead of a GUA (global unicast). Fixes: db853cc ("bgpd: Implement Link-Local Next Hop capability") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Fixes: db853cc ("bgpd: Implement Link-Local Next Hop capability") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This is to show if the NH address received as Link-Local Next Hop capability. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
cf90c2d to
84d9fe1
Compare
Even if we have unnumbered peering, let's respect `no neighbor X capability link-local` and disable it per-neighbor on demand. Fixes: db853cc ("bgpd: Implement Link-Local Next Hop capability") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
84d9fe1 to
6f42b09
Compare
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.