Skip to content

Conversation

aceelindem
Copy link
Collaborator

@aceelindem aceelindem commented Feb 6, 2025

Replace the LSDB callbacks with LSA update and delete hooks using the
the FRR hook mechanism. Remove redundant callbacks by placing the LSA
update and delete hooks in a single place so that deletes don't need
to be handled by the update hook. Simplify existing OSPF TE and OSPF
API Server callbacks now that there is no ambiguity or redundancy.
Also cleanup the debugging by separating out opaque-lsa debugging
from the overloaded event debugging.

@frrbot frrbot bot added the ospf label Feb 6, 2025
@github-actions github-actions bot added master size/L rebase PR needs rebase labels Feb 6, 2025
@aceelindem aceelindem force-pushed the aceelindem/ospf-lsa-add-delete-hook branch from 46bb398 to 18d74c5 Compare February 6, 2025 22:25
@Jafaral Jafaral marked this pull request as draft February 7, 2025 03:42
@aceelindem aceelindem force-pushed the aceelindem/ospf-lsa-add-delete-hook branch 2 times, most recently from 77a11a7 to 9378332 Compare February 7, 2025 15:29
@aceelindem
Copy link
Collaborator Author

CI:rerun

@aceelindem aceelindem force-pushed the aceelindem/ospf-lsa-add-delete-hook branch 4 times, most recently from 3bdfa79 to 083bd2c Compare February 10, 2025 21:46
@aceelindem
Copy link
Collaborator Author

CI:rerun

1 similar comment
@aceelindem
Copy link
Collaborator Author

CI:rerun

@riw777 riw777 self-requested a review February 11, 2025 13:53
@aceelindem aceelindem force-pushed the aceelindem/ospf-lsa-add-delete-hook branch 2 times, most recently from 403f800 to cdd7bea Compare February 11, 2025 22:11
@aceelindem aceelindem changed the title ospfd: Draft - Replace LSDB callbacks with LSA Update/Delete hooks. ospfd: Replace LSDB callbacks with LSA Update/Delete hooks. Feb 11, 2025
@aceelindem
Copy link
Collaborator Author

CI:rerun

@Jafaral Jafaral marked this pull request as ready for review February 12, 2025 03:10
Replace the LSDB callbacks with LSA update and delete hooks using the
the FRR hook mechanism. Remove redundant callbacks by placing the LSA
update and delete hooks in a single place so that deletes don't need
to be handled by the update hook. Simplify existing OSPF TE and OSPF
API Server callbacks now that there is no ambiguity or redundancy.
Also cleanup the debugging by separating out opaque-lsa debugging
from the overloaded event debugging.

Signed-off-by: Acee Lindem <acee@lindem.com>
@aceelindem aceelindem force-pushed the aceelindem/ospf-lsa-add-delete-hook branch from cdd7bea to b442584 Compare February 12, 2025 15:55
@aceelindem
Copy link
Collaborator Author

CI:rerun

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit fbff043 into FRRouting:master Feb 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants