zebra: include resolving nexthops in nhg hash #17935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the nhg hash comparison function includes all nexthops, including recursive-resolving nexthops. Signed-off-by: Mark Stapp <mjs@cisco.com>
Currently FRR does not handle v6 recurisive resolution properly when the route being recursed through changes and the most significant bits of the route are not changed. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
I've added Donald Sharp's topotest that exercises v6 resolution to this PR so that we include it. |
|
@Mergifyio backport dev/10.3 stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/8.4 |
✅ Backports have been created
|
This was referenced Feb 11, 2025
Jafaral
added a commit
that referenced
this pull request
Feb 11, 2025
zebra: include resolving nexthops in nhg hash (backport #17935)
donaldsharp
added a commit
that referenced
this pull request
Feb 12, 2025
zebra: include resolving nexthops in nhg hash (backport #17935)
donaldsharp
added a commit
that referenced
this pull request
Feb 12, 2025
zebra: include resolving nexthops in nhg hash (backport #17935)
donaldsharp
added a commit
that referenced
this pull request
Feb 12, 2025
zebra: include resolving nexthops in nhg hash (backport #17935)
donaldsharp
added a commit
that referenced
this pull request
Feb 12, 2025
zebra: include resolving nexthops in nhg hash (backport #17935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the nhg hash comparison function includes all nexthops, including recursive-resolving nexthops.
We discovered that the hash key computation does include the full recursion list, but this "equals" function did not, and that can lead to errors...