isisd: Allow full no form for domain-password and area-password
#17725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` LR1.wue3(config)# router isis VyOS LR1.wue3(config-router)# no area-password clear % Unknown command: no area-password clear LR1.wue3(config-router)# no area-password clear foo % Unknown command: no area-password clear foo LR1.wue3(config-router)# ``` Closes FRRouting#17722 Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
It looks tremendously similar to #17724 |
2 tasks
|
@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
ykholod
approved these changes
Dec 27, 2024
|
Fix working as expected - IS-IS configuration properly removed via frr-reload when applying this change to stable/10.2 |
c-po
approved these changes
Dec 29, 2024
This was referenced Jan 7, 2025
donaldsharp
added a commit
that referenced
this pull request
Jan 7, 2025
isisd: Allow full `no` form for `domain-password` and `area-password` (backport #17725)
donaldsharp
added a commit
that referenced
this pull request
Jan 7, 2025
isisd: Allow full `no` form for `domain-password` and `area-password` (backport #17725)
donaldsharp
added a commit
that referenced
this pull request
Jan 7, 2025
isisd: Allow full `no` form for `domain-password` and `area-password` (backport #17725)
donaldsharp
added a commit
that referenced
this pull request
Jan 7, 2025
isisd: Allow full `no` form for `domain-password` and `area-password` (backport #17725)
donaldsharp
added a commit
that referenced
this pull request
Jan 7, 2025
isisd: Allow full `no` form for `domain-password` and `area-password` (backport #17725)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17722