bgpd: compare aigp after local route check in bgp_path_info_cmp() (backport #17199) #17235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The topotest verifies that a local route is favored irrespective of its AIGP value. Signed-off-by: Enke Chen <enchen@paloaltonetworks.com> (cherry picked from commit 1a2c3d6) # Conflicts: # tests/topotests/bgp_aigp_rr/r1/bgpd.conf # tests/topotests/bgp_aigp_rr/r2/bgpd.conf # tests/topotests/bgp_aigp_rr/test_bgp_aigp_rr.py
For consistency between RIB and BGP, the aigp comparison should be made after the local route check in bgp bestpath selection. Signed-off-by: Enke Chen <enchen@paloaltonetworks.com> (cherry picked from commit 6a7049a)
|
Cherry-pick of 1a2c3d6 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Created a manual backport here #17239, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency between RIB and BGP, the aigp comparison should be made after the local route check in bgp bestpath selection.
As a reference, that's exactly what Cisco IOS does:
https://www.cisco.com/c/en/us/support/docs/ip/border-gateway-protocol-bgp/119001-configure-aigp-00.html
This is an automatic backport of pull request #17199 done by Mergify.