bgpd: fix AIGP calculation in route advertisement #17168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Oct 21, 2024
|
@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
|
Could you fix the styling? |
|
It seems the styling suggestions are about characters in a line (100?). That's optional, isn't it? |
|
Please use clang-format to ensure proper code indentation |
|
I have been using "checkpatch.pl". Is there a way to run the clang-format check myself? |
In this topotest, the route reflector advertises a route with the aigp attribute to its client, some with the nexthop unchanged and some with the nexthp changed. Different aigp values are sent to the clients depending on the nexthop setting. Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
Currently the AIGP is always incremented when a route with the attribute is advertised. That is incorrect when the nexthop is unchanged, as is commonly the case in route reflection. Adjust the AIGP for propagation only when the nexthop is set to ourselves. Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
9fe80cd to
fc82d77
Compare
ton31337
approved these changes
Oct 22, 2024
This was referenced Oct 22, 2024
Jafaral
added a commit
that referenced
this pull request
Oct 22, 2024
bgpd: fix AIGP calculation in route advertisement (backport #17168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the AIGP is always incremented when a route with the
attribute is advertised. That is incorrect when the nexthop is
unchanged, as is commonly the case in route reflection.
Adjust the AIGP for propagation only when the nexthop is set
to ourselves.