bgpd: Handle non-transitive extended communities #17151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb4f8f7 to
765a085
Compare
2 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
If we received a non-transitive extended community (in this case it was extended link-bandwidth), we treated it as unknown because we didn't check for the transitive flag correctly. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
…ceived correctly Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Extended communities can be transitive or non-transitive. Like other attributes (e.g., MED) non-transitive extended communities SHOULD be sent to the direct peer, but not forward them to eBGP peers next. Before this patch, we never send non-transitive extended attributes to the direct peers at all. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
…HECK_FLAG() Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
… peers Fixes: 765a085 ("bgpd: Rework extended community transitiviness") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
aefea72 to
60eff2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17142