Pw cleanup #17009
Merged
Pw cleanup #17009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Oct 6, 2024
ton31337
reviewed
Oct 6, 2024
Currently the pw code sets the status of the pw for install and uninstall immediately when notifying the dplane. This is incorrect in that we do not actually know the status at this point in time. When we get the result is when to set the status. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Currently the zebra pw code has setup a retry to install the pw after 30 seconds when it is decided that reachability to the pw is gone. This causes a failure mode where the pw code just goes and re-installs the pw after 30 seconds in the non-reachability case. Instead it should just be reinstalling after reachability is restored. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
6a79287 to
a8af2b2
Compare
2 tasks
donaldsharp
added a commit
to donaldsharp/frr
that referenced
this pull request
Oct 9, 2024
Recent PR FRRouting#17009 introduced a crash in pw handing for deletion. Let's fix that problem. Fixes: FRRouting#17041 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zice312963205
pushed a commit
to wenwang00/frr
that referenced
this pull request
Nov 28, 2024
Recent PR FRRouting#17009 introduced a crash in pw handing for deletion. Let's fix that problem. Fixes: FRRouting#17041 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zice312963205
pushed a commit
to wenwang00/frr
that referenced
this pull request
Nov 28, 2024
Recent PR FRRouting#17009 introduced a crash in pw handing for deletion. Let's fix that problem. Fixes: FRRouting#17041 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slight cleanup of where code was and also a small change to not automatically retry the installation of a pseudowire if it's reachability is down.