bfdd, yang: change bfd timer and multiplier values #17002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
requested changes
Oct 4, 2024
bfdd/bfdd_cli.c
Outdated
| @@ -357,7 +357,7 @@ void bfd_cli_show_mult(struct vty *vty, const struct lyd_node *dnode, | |||
|
|
|||
| DEFPY_YANG( | |||
| bfd_peer_rx, bfd_peer_rx_cmd, | |||
| "[no] receive-interval ![(10-60000)$interval]", | |||
| "[no] receive-interval ![(0-4294967)$interval]", | |||
c298c59 to
995b66c
Compare
Added |
idryzhov
requested changes
Oct 7, 2024
idryzhov
reviewed
Oct 7, 2024
The minimum and maximum values for BFD timers and multiplier settings have been updated to align with RFC 5880 requirements. Since the values inputted via VTY are in milliseconds, the maximum permissible value on the VTY interface is 4,294,967 milliseconds. For the multiplier setting, the minimum value is now restricted to be greater than zero, as zero is not allowed. The minimum transmit interval has been set to 10 milliseconds to ensure reliable service performance. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
995b66c to
244155a
Compare
idryzhov
approved these changes
Oct 8, 2024
|
ci:rerun |
1 similar comment
|
ci:rerun |
ton31337
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum and maximum values for BFD timers and multiplier settings have been updated to align with RFC 5880 requirements.
Since the values inputted via VTY are in milliseconds, the maximum permissible value on the VTY interface is 4,294,967 milliseconds.
For the multiplier setting, the minimum value is now restricted to be greater than zero, as zero is not allowed.
The minimum transmit interval has been set to 10 milliseconds to ensure reliable service performance.