isisd: Remove circuit state check for openfabric #17083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have something like: ``` int eth1 ip router openfabric x ipv6 router openfabric x ``` And eth1 is removed, the first `ip router ...` fails and only `ipv6 router ...` is enabled. If we leave only: ``` int eth1 ipv6 router openfabric x ``` Then also, no interface is going to be enabled, which is weird too. Fixes: FRRouting#17075 Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2 tasks
|
It would be nice to remove this code entirely and replace it with code matching the newer draft ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17075