lib: Apply and generate route-map commands earlier before any other protocol #17058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rotocol If e.g. BGP neighbor is using a route-map at the boot, that is not yet created, then the log is spammed with `The route-map 'X' does not exist`. Processing earlier, should do the trick. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
I would prefer that we have a general discussion during the weekly meeting about doing a change like this before any decision to put this in is made |
|
Sure, I wanted to test it first if nothing is broken in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #17052