tools: add logfmt option for frr-reload.py #16796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcec885 to
a5f4cac
Compare
|
What is the real case it would be helpful? |
This is useful for integrating with observability stacks, as logfmt is a common format for machine-readable logs. It enhances log parsing and visualization in tools like Prometheus and Grafana. We might consider using the logfmter library for a more standardized implementation. If we prefer using the library, I'll be happy to replace my implementation with that. |
|
IMO it's better without 3rd party libraries in this place as it might complicate things (installing). Two bullets to solve still regarding this PR:
|
a5f4cac to
52f409f
Compare
|
ci:rerun CI stuck |
52f409f to
b5a02ac
Compare
e1028db to
4f5a152
Compare
Adopt f-string for printing log message, so that appropriate formatting can be applied. Signed-off-by: Giovanni Tataranni <g.tataranni@gmail.com>
4f5a152 to
7ae71ae
Compare
|
@ton31337 Changes done, please review |
|
CI:rerun |
ton31337
reviewed
Feb 14, 2025
Add the option of printing logs in logfmt format.
Additional machine readable information can be printed via the `extra`
argument.
Example:
```python
log.debug("exit context"), extra={"line": line, "ctx_keys": ctx_keys})
log.error(f"Failed to execute command {' '.join(cmd)}", extra={"cmd": cmd})
```
Signed-off-by: Giovanni Tataranni <g.tataranni@gmail.com>
7ae71ae to
44a6e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option of printing logs in logfmt format.
Adopt f-string for printing log message, so that appropriate formatting can be applied.
Additional machine readable information can be printed via the
extraargument.Example: