Skip to content

Conversation

weihanglo
Copy link
Contributor

Resolves #68

This adds support of <addition-expression> in SPDX v3 specification:

addition-ref = [%s"DocumentRef-"(idstring)":"]%s"AdditionRef-"(idstring)
addition-expression = license-exception-id / addition-ref

See https://spdx.github.io/spdx-spec/v3.0.1/annexes/spdx-license-expressions/

BREAKING: SemVer major breakage with new enum variants and struct fields.


The motivation of this is rust-lang/cargo#15847 btw

Resolves EmbarkStudios#68

This adds support of `<addition-expression>` in SPDX v3 specification:

```
addition-ref = [%s"DocumentRef-"(idstring)":"]%s"AdditionRef-"(idstring)
addition-expression = license-exception-id / addition-ref
```

See https://spdx.github.io/spdx-spec/v3.0.1/annexes/spdx-license-expressions/

BREAKING: SemVer major breakage with new enum variants and struct fields.
@weihanglo weihanglo requested a review from Jake-Shadle as a code owner August 19, 2025 03:46
@Jake-Shadle Jake-Shadle changed the title feat!: support AdditionRef in SPDX v3 Support AdditionRef Aug 19, 2025
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jake-Shadle Jake-Shadle merged commit 8f4e75a into EmbarkStudios:main Aug 19, 2025
5 checks passed
@weihanglo weihanglo deleted the additionref branch August 19, 2025 06:22
@weihanglo
Copy link
Contributor Author

Thank you for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to spec v3
2 participants