Pin pandas to avoid broken round function
#2305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2305 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 238 238
Lines 13122 13123 +1
=======================================
+ Hits 12299 12300 +1
Misses 823 823 ☔ View full report in Codecov by Sentry. |
valeriupredoi
approved these changes
Jan 22, 2024
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
|
many thanks, Manu 🍺 |
4 tasks
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes recent test failures that are caused by a bug in pandas. This bug breaks the
roundfunction that we use to round to the nearest second:ESMValCore/esmvalcore/cmor/_fixes/icon/icon.py
Lines 495 to 497 in d6008f3
In addition, this removes the use of two deprecated features:
DatetimeProperties.to_pydatetimebynp.arrayas recommended in the deprecation message. Unfortunately, this does not remove the warning, but hopefully this will avoid problems in the future.Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: