-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix Windows Builds #6106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows Builds #6106
Conversation
To be tested on Windows machines |
x64 build is still broken - shouldn't the |
https://github.com/Jai-JAP/tabby/actions/runs/2141322690
|
https://github.com/Jai-JAP/tabby/actions/runs/2141391555 Here are the latest builds
|
31f549f works on Windows x64 |
579b602 broke it again, the new condition is equivalent to
|
Shouldn't it be just |
I will commit this and again can you try the build as my windows system is broken |
Also fixed the same in build-linux.js |
Aftifacts |
@Eugeny Have you tested the Mac OS x86_64 builds as they may also have the same issue as mentioned in #6106 (comment) |
Windows x64 build is tested working on my friend's PC |
macOS x64 confirmed working |
Ok then... |
Fixes Windows arm64 builds and probably doesnt break windows x64 builds
Artifacts here