Add Pentanomial LLR and use nelo bounds for SPRT #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gonna trust you on the maths on this one :D Probably in the future the llr should just take a Stats object |
|
for the penta llr i didn't take them from fishtest instead i used my own 5-nomial distribution code combined with the cpw llr formula that i used on my python elo and SPRT simulator here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overloaded the LLR function to provide pentanomial LLR when called with pentanomial results. This allows for pentanomial SPRT's. Also made the elo0 and elo1 bounds for SPRT use normalized elo instead of logistic elo to be consistent with Fishtest and Openbench.