add support for gzipped books #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
main reason for the zlib flag is that a) i think zlib is not by default available and b) licensing |
|
Right! I had forgotten about the lib itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to specify the book names
foo.epd.gzorbar.pgn.gz, and the files will be decompressed on the fly.I find this feature very convenient, and it may allow to streamline the book handling for Fishtest in future.
If this is merged, some checks may need to be added to the CI to see that this works on all architectures (it should).
Also, it may be time to retire the
ZLIBmakefile flag and always compile with zlib support.