[Attached feature] Crash when handling large images #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solve an issue where Degate were crashing or freezing when loading many tiles. Since there was no limit on thread creation, this would end in too many created thread and make the application unresponsive. The available thread number is configurable directly in the preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try to fix current limitations of the multi-threading system of the attached project type. The idea is to have a new cache system that can cancel no-longer-needed tiles being loaded (which, if working on a huge image, can make exhaust the thread pool and crash/freeze Degate).
Affected area(s)
Changes type
Proposed changes