Skip to content

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Feb 8, 2021

  • Needs tests
  • Set version number in FlutterCapabilities

Fixes #3009.

@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps in testing Relates to test execution of Dart/Flutter tests for end users labels Feb 8, 2021
@DanTup DanTup added this to the v3.20.0 milestone Feb 8, 2021
@DanTup DanTup force-pushed the integration-test-support branch 2 times, most recently from 24927a5 to c49315d Compare February 12, 2021 15:46
@DanTup DanTup modified the milestones: v3.20.0, v3.21.0 Feb 17, 2021
@DanTup DanTup modified the milestones: v3.21.0, v3.22 Mar 22, 2021
@jiahaog
Copy link

jiahaog commented Mar 31, 2021

Thanks! Just tested this out manually (running, debugging) on macOS with a few devices connected and it seems to work great (after patching the version in src/shared/capabilities/flutter.ts)! I filed an issue for expression evaluation (flutter/flutter#79439) but other than that are there any other edge cases that we should be concerned about?

@DanTup
Copy link
Member Author

DanTup commented Apr 1, 2021

Great! I'm not sure if there may be anything else, but perhaps I think I have integration tests here that do a bunch of things for flutter test (inc. expression eval etc.), so maybe I can get them to run over an integration test too to give some more coverage. I'll fix this branch up and work on the tests and let you know if I find any issues.

DanTup added 4 commits April 13, 2021 12:02
This appears to not be supported anymore (at least when there is a plugin, like integration_test in dev_dependencies).
@DanTup DanTup force-pushed the integration-test-support branch from 1db97ea to 675b6ca Compare April 13, 2021 12:09
@DanTup DanTup marked this pull request as ready for review April 13, 2021 12:10
@DanTup
Copy link
Member Author

DanTup commented Apr 15, 2021

I've re-tested this and added a few tests, and all seems good to me. Based on flutter/flutter@9e3eadb, I'm setting the version number to enable this as 2.2.0-10 since that changeset appears to first exist in 2.2.0-10.0.pre.

@DanTup DanTup merged commit 872c26e into master Apr 15, 2021
@DanTup DanTup deleted the integration-test-support branch April 15, 2021 10:43
@jiahaog
Copy link

jiahaog commented Apr 16, 2021

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in flutter Relates to running Flutter apps in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test with integration_test package
2 participants