-
Notifications
You must be signed in to change notification settings - Fork 0
Circleci project setup #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR introduces a basic CircleCI pipeline and delivers a coordinated patch release (v47.0.1) across our CLI and runtime packages by bumping versions, updating dependencies, refreshing changelogs, and removing stale changesets. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on integrating CircleCI into the project to automate build and test processes. Concurrently, it includes routine patch version updates across several core @vercel packages, incorporating recent bug fixes and minor enhancements that were previously documented in temporary changeset files.
Highlights
- Initial CircleCI Setup: A new .circleci/config.yml file has been added to establish continuous integration for the project, including a basic "say-hello" job.
- Package Version Bumps: Multiple @vercel packages, including @vercel/cli, @vercel/express, @vercel/hono, @vercel/next, and @vercel/node, have received patch version updates.
- Specific Fixes and Features Included in Patch Releases: @vercel/next now correctly handles rewrite headers, preventing schema validation failures for empty headers. Additionally, @vercel/hono and @vercel/node now consistently compile .mts files to ESM.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a basic CircleCI configuration and updates package versions across the repository. The changes are generally good, but I've provided a suggestion to improve the CI configuration's reproducibility by pinning the Docker image to a specific version. This will help prevent unexpected build failures in the future.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@47.0.1 ### Patch Changes - Updated dependencies \[[`17f3c91aa96ce272d265d809f3b765a12a1f38b3`](vercel@17f3c91), [`fea94eea32f9df7c72d9ea95434d84c44f4ef082`](vercel@fea94ee)]: - @vercel/next@4.12.4 - @vercel/hono@0.0.20 - @vercel/node@5.3.19 - @vercel/express@0.0.12 ## @vercel/express@0.0.12 ### Patch Changes - Updated dependencies \[[`fea94eea32f9df7c72d9ea95434d84c44f4ef082`](vercel@fea94ee)]: - @vercel/node@5.3.19 ## @vercel/hono@0.0.20 ### Patch Changes - Always compile `.mts` to ESM ([vercel#13693](vercel#13693)) - Updated dependencies \[[`fea94eea32f9df7c72d9ea95434d84c44f4ef082`](vercel@fea94ee)]: - @vercel/node@5.3.19 ## @vercel/next@4.12.4 ### Patch Changes - Skip adding rewrite headers when the destination has no rewritten pathname or query (and when external origin is not allowed). This prevents generating an empty `rewrite.headers` object that fails schema validation and restores previous behavior for external or no-op rewrites. ([vercel#13844](vercel#13844)) ## @vercel/node@5.3.19 ### Patch Changes - Always compile `.mts` to ESM ([vercel#13693](vercel#13693)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
0fc1ca9
to
34504e5
Compare
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary by Sourcery
Add a basic CircleCI configuration and publish patch releases for the CLI and core runtimes with corresponding changelog updates
New Features:
Bug Fixes:
Enhancements:
Chores: