Marshaler support for interface field types. #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand interface check beyond the immediate type of the value. This allows for custom marshaling of structures with interface and indirect field types.
|
Thanks for submitting this! Sorry about leaving you on read for a week; I will try to get to this review over the weekend! 🙂 |
DHowett
approved these changes
Nov 2, 2022
|
Merged in 663ca47! |
chihqiang
pushed a commit
to pkg6/go-plist
that referenced
this pull request
May 20, 2025
Expand interface check beyond the immediate type of the value. This allows for custom marshaling of structures with interface and indirect field types. Closes DHowett#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand interface checks beyond the immediate value type. This allows values that implement the
Marshalerinterface but are validly assigned to fields with non-implementing types, such asinterface{}.See
TestInterfaceFieldMarshalfor an example of this behaviour.