Skip to content

Conversation

Myestery
Copy link
Contributor

@Myestery Myestery commented Jun 22, 2025

fix #1179

┆Issue is synchronized with this Notion page by Unito

Requires label New Browser Test Expectations
See sample run here Myestery#2

@Myestery Myestery requested a review from a team as a code owner June 22, 2025 18:28
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jun 22, 2025
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this workflow to automate test expectation updates! This is a valuable addition to our CI/CD pipeline.

I've identified one issue that needs to be addressed:

Line 30: The current implementation uses npm run test:e2e, which works well for adding new screenshot tests (as demonstrated in your test PR), but won't update existing snapshots when visual changes are made to features.

To handle both scenarios (new snapshots and updating existing ones), please change line 30 from:

run: npm run test:e2e

to:

run: npm run test:e2e:update

This will pass the --update-snapshots flag to Playwright, ensuring that both new and modified screenshots are properly captured and committed.

Once this change is made, the workflow should handle all test expectation update scenarios correctly.

@Myestery
Copy link
Contributor Author

Hi @christian-byrne
Thanks for the review. I've been able to add the update command

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2025
@christian-byrne christian-byrne merged commit 2deb58b into Comfy-Org:main Jun 25, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Create playwright test expectation update script
3 participants