-
Notifications
You must be signed in to change notification settings - Fork 138
Add workflow for playwright test expectation #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ds and ensure consistent naming for test results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this workflow to automate test expectation updates! This is a valuable addition to our CI/CD pipeline.
I've identified one issue that needs to be addressed:
Line 30: The current implementation uses npm run test:e2e
, which works well for adding new screenshot tests (as demonstrated in your test PR), but won't update existing snapshots when visual changes are made to features.
To handle both scenarios (new snapshots and updating existing ones), please change line 30 from:
run: npm run test:e2e
to:
run: npm run test:e2e:update
This will pass the --update-snapshots
flag to Playwright, ensuring that both new and modified screenshots are properly captured and committed.
Once this change is made, the workflow should handle all test expectation update scenarios correctly.
Hi @christian-byrne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fix #1179
┆Issue is synchronized with this Notion page by Unito
Requires label
New Browser Test Expectations
See sample run here Myestery#2