Skip to content

Conversation

comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Aug 15, 2025

Backport of #5023 to core/1.25

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…5023)

When saving workflows with nested subgraphs, promoted widget values were not being synchronized back to the subgraph definitions before serialization. This caused widget values to revert to their original defaults when reloading the workflow.

The fix overrides the serialize() method in SubgraphNode to sync promoted widget values to their corresponding widgets in the subgraph definition before serialization occurs.

Fixes the issue where nested subgraph widget values would be lost after save/reload.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 15, 2025
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner August 15, 2025 21:35
Copy link

github-actions bot commented Aug 15, 2025

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

@christian-byrne christian-byrne merged commit 5918dde into core/1.25 Aug 15, 2025
15 checks passed
@christian-byrne christian-byrne deleted the backport-5023-to-1.25 branch August 15, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backporting a PR onto a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants