Skip to content

Conversation

comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Aug 17, 2025

Backport of #5054 to core/1.25

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…nodes (#5054)

* [fix] resolve group node execution error when connecting to external nodes

Fixed ExecutableGroupNodeChildDTO.resolveInput to properly handle connections from group node children to external nodes. The method now tries to find nodes by their full ID first (for external nodes) before falling back to the shortened ID (for internal group nodes).

Added comprehensive unit tests to prevent regression.

* [feat] Add error check for unsupported group nodes inside subgraphs

Added validation to detect when group node children are executing within subgraph contexts (execution ID has >2 segments) and provide clear error message directing users to convert to subgraphs instead.

Includes comprehensive test coverage for the new validation.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 17, 2025
@comfy-pr-bot comfy-pr-bot requested review from a team as code owners August 17, 2025 23:39
Copy link

github-actions bot commented Aug 17, 2025

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

@christian-byrne christian-byrne merged commit 397699a into core/1.25 Aug 18, 2025
15 checks passed
@christian-byrne christian-byrne deleted the backport-5054-to-1.25 branch August 18, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backporting a PR onto a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants