Skip to content

Fix message for one of the WinRT diagnostics #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix message for one of the WinRT diagnostics #999

merged 1 commit into from
Nov 22, 2024

Conversation

Sergio0694
Copy link
Member

Small follow up PR to fix a diagnostic message.

PR Checklist

  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Nov 22, 2024
@Sergio0694 Sergio0694 changed the title Fix 'WinRTGeneratedBindableCustomPropertyWithBaseObservablePropertyOnField' Fix message for one of the WinRT diagnostics Nov 22, 2024
@Sergio0694 Sergio0694 merged commit 60ff03e into main Nov 22, 2024
3 checks passed
@Sergio0694 Sergio0694 deleted the dev/fix-diagnostic-message branch November 22, 2024 21:19
This was referenced Aug 1, 2025
Closed
Open
Open
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694