Skip to content

Fix suppressions for custom attribute targets #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix suppressions for custom attribute targets #964

merged 1 commit into from
Oct 23, 2024

Conversation

Sergio0694
Copy link
Member

This PR fixes the suppression diagnostics in one of the diagnostic suppressors, which was just throwing at runtime.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added the bugfix 🔧 PRs fixing a discovered bug label Oct 23, 2024
@Sergio0694 Sergio0694 merged commit ba45963 into main Oct 23, 2024
3 checks passed
@Sergio0694 Sergio0694 deleted the dev/fix-attribute-target-suppression branch October 23, 2024 05:21
This was referenced Aug 1, 2025
Closed
Open
Open
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix 🔧 PRs fixing a discovered bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694