Skip to content

Allow forwarding attributes to property accessors #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2024
Merged

Allow forwarding attributes to property accessors #946

merged 4 commits into from
Sep 18, 2024

Conversation

Sergio0694
Copy link
Member

Closes #939

This PR allows forwarding attributes to generated property accessors for fields annotated with [ObservableProperty].

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Sep 9, 2024
@Sergio0694 Sergio0694 force-pushed the dev/forward-accessor-attributes branch from 8c5c932 to 3c986b2 Compare September 9, 2024 19:58
@Sergio0694 Sergio0694 force-pushed the dev/forward-accessor-attributes branch from 0cbf421 to 8404e3a Compare September 18, 2024 15:31
@Sergio0694 Sergio0694 merged commit cb478f1 into main Sep 18, 2024
4 checks passed
@Sergio0694 Sergio0694 deleted the dev/forward-accessor-attributes branch September 18, 2024 16:28
This was referenced Aug 1, 2025
Closed
Open
Open
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ObservableProperty] with OnPropertyChanged partial(s) which update additional properties mask nullability analysis - CS8618
1 participant
@Sergio0694