Skip to content

Allow trimming feature switches #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 20, 2024
Merged

Allow trimming feature switches #911

merged 6 commits into from
Aug 20, 2024

Conversation

Sergio0694
Copy link
Member

This PR enables trimming the feature switches in the MVVM Toolkit.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventionsformation that might be helpful to reviewers. -->

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Aug 9, 2024
@Sergio0694 Sergio0694 force-pushed the dev/trim-feature-switches branch 2 times, most recently from 02f125e to 49dd354 Compare August 9, 2024 01:54
@Sergio0694 Sergio0694 force-pushed the dev/trim-feature-switches branch from 49dd354 to f3903a1 Compare August 9, 2024 02:31
@echoix
Copy link

echoix commented Aug 9, 2024

Small note: There's a typo in the last word of the title, before using it as a commit message

@Sergio0694
Copy link
Member Author

Oops, good catch ahah, thank you 😄

@Sergio0694 Sergio0694 changed the title Allow trimming feature swithes Allow trimming feature switches Aug 9, 2024
@Sergio0694
Copy link
Member Author

Validated locally that the method is entirely removed:

image

@Sergio0694 Sergio0694 merged commit cc35d3f into main Aug 20, 2024
4 checks passed
@Sergio0694 Sergio0694 deleted the dev/trim-feature-switches branch August 20, 2024 16:49
@Sergio0694 Sergio0694 mentioned this pull request Aug 20, 2024
Merged
9 tasks
This was referenced Aug 1, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sergio0694 @echoix