Skip to content

Conversation

Sergio0694
Copy link
Member

This PR improves trim support by also generating a trim annotation when [NotifyDataErrorInfo] is used.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions any other information that might be helpful to reviewers. -->

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Aug 22, 2024
@Sergio0694 Sergio0694 merged commit af626a6 into main Aug 22, 2024
4 checks passed
@Sergio0694 Sergio0694 deleted the dev/observable-validator-trim-generator branch August 22, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 👓 A new analyzer being implemented or updated improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant