Skip to content

Add AOT support in WinRT scenarios to the MVVM Toolkit #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2024
Merged

Add AOT support in WinRT scenarios to the MVVM Toolkit #909

merged 4 commits into from
Aug 8, 2024

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Aug 8, 2024 •
edited
Loading

Fixes #892

This PR adds the Windows TFM to the MVVM Toolkit, and makes it AOT compatible for WinRT interop.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality next preview ✈️ This changes will be available in the upcoming preview mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Aug 8, 2024
manodasanW
manodasanW reviewed Aug 8, 2024
View reviewed changes
manodasanW
manodasanW reviewed Aug 8, 2024
View reviewed changes
@Sergio0694 Sergio0694 merged commit e7acd48 into main Aug 8, 2024
4 checks passed
@Sergio0694 Sergio0694 deleted the dev/winrt-aot branch August 8, 2024 17:11
@Sergio0694 Sergio0694 mentioned this pull request Aug 9, 2024
Closed
This was referenced Aug 1, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@manodasanW manodasanW manodasanW left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommunityToolkit.Mvvm cannot work with aot
2 participants
@Sergio0694 @manodasanW