Skip to content

Added Stream over ReadOnlySequence<byte> #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2024
Merged

Added Stream over ReadOnlySequence<byte> #808

merged 3 commits into from
Nov 21, 2024

Conversation

paulomorgado
Copy link
Contributor

@paulomorgado paulomorgado commented Dec 7, 2023 •
edited
Loading

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

This PR adds a AsStream() extension method to ReadOnlySequence<byte> similarly to the same method for Memory<byte> and ReadOnlyMemory<byte>.

@paulomorgado paulomorgado force-pushed the feature/readonlysequencestream branch from 979aece to 24fe7d7 Compare August 27, 2024 17:37
@paulomorgado paulomorgado force-pushed the feature/readonlysequencestream branch from 24fe7d7 to e9aba04 Compare September 18, 2024 19:06
@Sergio0694
Copy link
Member

Could you please rebase on top of main and drop all other commits except the 2 from you? Thank you 🙂

@paulomorgado paulomorgado force-pushed the feature/readonlysequencestream branch 3 times, most recently from 4865cb5 to 09a148d Compare November 16, 2024 13:22
@paulomorgado
Copy link
Contributor Author

Could you please rebase on top of main and drop all other commits except the 2 from you? Thank you 🙂

Done! 😄

@Sergio0694 Sergio0694 force-pushed the feature/readonlysequencestream branch from 09a148d to b292ab9 Compare November 20, 2024 00:26
@Sergio0694 Sergio0694 force-pushed the feature/readonlysequencestream branch from b292ab9 to b8aa65a Compare November 20, 2024 00:26
@Sergio0694 Sergio0694 force-pushed the feature/readonlysequencestream branch from 5551616 to bd49681 Compare November 21, 2024 01:30
Sergio0694
Sergio0694 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🙂

@Sergio0694 Sergio0694 merged commit c72bfca into CommunityToolkit:main Nov 21, 2024
4 checks passed
This was referenced Aug 1, 2025
Closed
Open
Open
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

+1 more reviewer

@DaZombieKiller DaZombieKiller DaZombieKiller left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulomorgado @Sergio0694 @DaZombieKiller