Skip to content

Add [MemberNotNull] to [ObservableProperty] set accessors #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2023
Merged

Add [MemberNotNull] to [ObservableProperty] set accessors #646

merged 3 commits into from
Mar 14, 2023

Conversation

Sergio0694
Copy link
Member

Closes #645

cc. @Youssef1313 for your consideration if you have spare time once again 😄

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Mar 14, 2023
@Sergio0694 Sergio0694 requested a review from Arlodotexe March 14, 2023 13:09
@Sergio0694 Sergio0694 force-pushed the dev/observable-property-membernotnull branch from de885cb to 7ac93b3 Compare March 14, 2023 17:30
@Sergio0694 Sergio0694 force-pushed the dev/observable-property-membernotnull branch from 7ac93b3 to 673801a Compare March 14, 2023 17:34
@Sergio0694 Sergio0694 merged commit b8df95a into main Mar 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/observable-property-membernotnull branch March 14, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Awaiting requested review from Arlodotexe

2 more reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
No open projects
8.2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add [MemberNotNull] on [ObservableProperty] setter when needed
3 participants
@Sergio0694 @jkoritzinsky @Youssef1313