Skip to content

Resolve all needed symbols early in analyzers #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2023
Merged

Resolve all needed symbols early in analyzers #587

merged 3 commits into from
Feb 1, 2023

Conversation

Sergio0694
Copy link
Member

Closes #586

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Jan 26, 2023
@Sergio0694
Copy link
Member Author

@Youssef1313 thank you for the suggestion! And feel free to take a look 😄

@Sergio0694 Sergio0694 force-pushed the dev/resolve-symbols-early branch 3 times, most recently from 941fcbd to 9b96497 Compare January 31, 2023 13:26
@Sergio0694 Sergio0694 force-pushed the dev/resolve-symbols-early branch from 9b96497 to afad5d2 Compare January 31, 2023 23:30
@Sergio0694 Sergio0694 merged commit af3cb96 into main Feb 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/resolve-symbols-early branch February 1, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Youssef1313 Youssef1313 Youssef1313 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
No open projects
8.2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve symbols early in all analyzers
2 participants
@Sergio0694 @Youssef1313