Skip to content

Add Anisotropic Sampling option to ZZZ GSP #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2025
Merged

Add Anisotropic Sampling option to ZZZ GSP #703

merged 4 commits into from
Mar 22, 2025

Conversation

Cryotechnic
Copy link
Collaborator

AKA Anisotropic Filtering, but kept the in-game name for clarity. All presets seem to not change the value, keeping it at x8.

Main Goal

Update ZZZ GSP so that it is in parity with the in-game options.

PR Status :

  • Overall Status : Done ✅
  • Commits : Done ✅
  • Synced to base (Collapse:main) : Yes ✅
  • Build status : OK ✅
  • Crashing : No

Changes:

  • [New] Added new dropdown menu for Anisotropic Sampling option (x1, x2, x4, x8, x16), with x8 as default
    • [Loc] Added new i18n string for option

@Cryotechnic
Add Anisotropic Sampling option to ZZZ GSP
21df6d8 
AKA Anisotropic Filtering, but kept the in-game name for clarity. All presets seem to not change the value, keeping it at x8.
@Cryotechnic
Merge branch 'main' into imp/zzz-gsp-16
23b77ee
@Cryotechnic Cryotechnic requested a review from bagusnl March 16, 2025 20:03
@Cryotechnic Cryotechnic self-assigned this Mar 16, 2025
bagusnl
bagusnl approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ack'd

These are just some regular comments, but I think for the localization one you can reuse instead of remaking the entry

@bagusnl
Copy link
Member

bagusnl commented Mar 22, 2025

Merged as discussed in Discord

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bagusnl bagusnl merged commit e0d3782 into main Mar 22, 2025
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2025 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 70 dependencies

Third-party software list

This page lists the third-party software dependencies used in CollapseLauncher

Dependency Version Licenses
CommunityToolkit.Common 8.4.0 MIT
CommunityToolkit.Mvvm 8.4.0 MIT
CommunityToolkit.WinUI.Animations 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Behaviors 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Controls.Primitives 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Controls.Sizers 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Converters 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Extensions 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Helpers 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Media 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Triggers 8.2.250129-preview2 MIT
Costura.Fody 6.0.0 MIT
DependencyPropertyGenerator 1.5.0 MIT
DotNet.ReproducibleBuilds 1.2.25 MIT
EventGenerator.Generator 0.13.1 MIT
Fody 6.9.2 MIT
GitInfo 3.5.0 MIT
Google.Protobuf.Tools 3.30.0 PROTOBUF
Google.Protobuf 3.30.0 BSD-3-Clause
Hi3Helper.ZstdNet 1.6.4 BSD-3-Clause
HtmlAgilityPack 1.11.74 MIT
Markdig.Signed 0.40.0 BSD-2-Clause
Microsoft.CSharp 4.7.0 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 9.0.3 MIT
Microsoft.Extensions.DependencyInjection 9.0.3 MIT
Microsoft.Extensions.Logging.Abstractions 9.0.3 MIT
Microsoft.Extensions.Logging 9.0.3 MIT
Microsoft.Extensions.Options 9.0.3 MIT
Microsoft.Extensions.Primitives 9.0.3 MIT
Microsoft.Graphics.Win2D 1.3.2 MS-ASP-NET-WEB-OPTIMIZATION
Microsoft.NET.ILLink.Tasks 9.0.1 MIT
Microsoft.NET.ILLink.Tasks 9.0.3 MIT
Microsoft.NETCore.Targets 6.0.0-preview.4.21253.7 MIT
Microsoft.Web.WebView2 1.0.3065.39 BSD-3-Clause
BSD-MYLEX
Microsoft.Win32.SystemEvents 9.0.3 MIT
Microsoft.Windows.CsWin32 0.3.183 Apache-2.0
Microsoft.Windows.CsWinRT 2.2.0 MIT
Microsoft.Windows.SDK.BuildTools 10.0.22621.3233 PROPRIETARY-LICENSE
Microsoft.Windows.SDK.BuildTools 10.0.26100.1742 PROPRIETARY-LICENSE
Microsoft.Windows.SDK.Win32Docs 0.1.42-alpha PROPRIETARY-LICENSE
Microsoft.Windows.SDK.Win32Metadata 61.0.15-preview MIT
Microsoft.Windows.WDK.Win32Metadata 0.12.8-experimental MIT
Microsoft.WindowsAppSDK 1.6.250205002 MIT
MS-DXSDK-D3DX-9.29.952.3
Microsoft.Xaml.Behaviors.WinUI.Managed 3.0.0 MIT
MinVer 6.0.0 Apache-2.0
NuGet.Versioning 6.12.1 Apache-2.0
PhotoSauce.MagicScaler 0.15.0 MIT
PhotoSauce.NativeCodecs.Libwebp 1.4.0-preview1 MIT
Roman-Numerals 2.0.1 MIT
Sentry 5.2.0 MIT
SharpCompress 0.39.0 MIT
SharpHDiffPatch.Core 2.2.8 MIT
System.Buffers 4.6.0 MIT
System.Drawing.Common 9.0.3 MIT
System.IO.Hashing 9.0.3 MIT
System.Net.Http 4.3.4 MIT
System.Security.AccessControl 6.0.1 MIT
System.Security.Cryptography.Algorithms 4.3.0 MIT
System.Security.Cryptography.Encoding 4.3.0 MIT
System.Security.Cryptography.Primitives 4.3.0 MIT
System.Security.Cryptography.ProtectedData 9.0.3 MIT
System.Security.Cryptography.X509Certificates 4.3.0 MIT
System.Text.Encoding.CodePages 9.0.3 MIT
System.Text.Json 9.0.3 MIT
System.Text.RegularExpressions 4.3.1 MIT
System.Threading.Tasks.Extensions 4.5.4 MIT
TaskScheduler 2.12.1 MIT
ThisAssembly.Constants 2.0.6 MIT
Velopack 0.0.1053 MIT
ZstdSharp.Port 0.8.4 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@neon-nyan neon-nyan deleted the imp/zzz-gsp-16 branch April 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagusnl bagusnl bagusnl approved these changes

Assignees

@Cryotechnic Cryotechnic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cryotechnic @bagusnl