Skip to content

Refactor #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 2, 2022
Merged

Refactor #37

merged 13 commits into from
Jan 2, 2022

Conversation

Code-Hex
Copy link
Owner

@Code-Hex Code-Hex commented Jan 1, 2022 •
edited
Loading

  • breaking changes included
    • removed -d --target-dir option. use -o option
    • some function signatures in pget package
  • update goreleaser
  • update actions

@codecov
Copy link

codecov bot commented Jan 1, 2022 •
edited
Loading

Codecov Report

Merging #37 (94eb788) into master (68b641a) will increase coverage by 0.37%.
The diff coverage is 70.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   66.36%   66.73%   +0.37%     
==========================================
  Files           5        6       +1     
  Lines         333      478     +145     
==========================================
+ Hits          221      319      +98     
- Misses         72      117      +45     
- Partials       40       42       +2
Impacted Files Coverage Δ
option.go 80.00% <50.00%> (-2.15%) ⬇️
error.go 61.11% <61.11%> (ø)
pget.go 54.47% <65.90%> (+7.80%) ⬆️
requests.go 64.70% <70.76%> (-7.93%) ⬇️
download.go 71.59% <71.59%> (ø)
util.go 77.08% <82.60%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b641a...94eb788. Read the comment docs.

@Code-Hex Code-Hex marked this pull request as ready for review January 2, 2022 04:40
@Code-Hex
Copy link
Owner Author

Code-Hex commented Jan 2, 2022

#36

@Code-Hex Code-Hex changed the title WIP: Refactor Refactor Jan 2, 2022
@Code-Hex Code-Hex merged commit 0f35aee into master Jan 2, 2022
@Code-Hex Code-Hex deleted the refactor branch January 2, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Code-Hex