Skip to content

[TargetDefinition] Add swift_version to target_definition #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2016
Merged

[TargetDefinition] Add swift_version to target_definition #342

merged 1 commit into from
Jul 5, 2016

Conversation

endocrimes
Copy link
Member

@endocrimes endocrimes mentioned this pull request Jul 2, 2016
Merged
@segiddins
Copy link
Member

👍 with test coverage

@endocrimes endocrimes force-pushed the dan_swift_version branch from 19a3191 to 9edf829 Compare July 3, 2016 15:44
@endocrimes
Copy link
Member Author

@segiddins 👍, done!

@endocrimes endocrimes force-pushed the dan_swift_version branch from 9edf829 to 2b72b2c Compare July 4, 2016 02:50
segiddins
segiddins reviewed Jul 5, 2016
View reviewed changes
lib/cocoapods-core/podfile/target_definition.rb
set_hash_value('swift_version', version)
end

# @return [Bool] whether the target definition should build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment looks copy-pasted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Will fix in a mo

@endocrimes endocrimes force-pushed the dan_swift_version branch from 2b72b2c to 64e2fd2 Compare July 5, 2016 14:15
@segiddins segiddins merged commit 56a87a1 into CocoaPods:master Jul 5, 2016
@segiddins segiddins deleted the dan_swift_version branch July 5, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endocrimes @segiddins