Fix shellscript in '📦 Check Pods Manifest.lock' #5595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 with a CHANGELOG, we'll also have to rebuild the integration specs |
|
Thanks for feedback. I am a novice in all this CocoaPods Ruby magic. Is there anything else apart from the CHANGELOG entry, I can do? |
| EOM | ||
| if [ $? != 0 ] ; then | ||
| # print error to STDERR | ||
| echo "error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation." >&2 |
There was a problem hiding this comment.
Any reason why this was changed to echo?
There was a problem hiding this comment.
I'm glad you ask:
- It is one line instead of three
- echo is a built-in in most shells and usually faster because it avoids a process (confirm
which catandwhich echoin the shell of your choice) - cat is a tool made for concatenating files. Whenever cat is used with only one file, it is likely to be abused
- Combining the reading from STDIN (the
<< EOMpart) with the redirect to stderr (>&2) would be hard to unserstand syntactically
So the more interesting question would be, why ever someone started using cat for this.
added 3 commits
July 6, 2016 10:33
The script is integrated using /bin/sh but [[ is not defined in generic POSIX shell. Confirm shellcheck error: if [[ $? != 0 ]] ; then ^-- SC2039: In POSIX sh, [[ ]] is undefined. This works right now, because on common OS X systems, /bin/sh is Bash. But this might change in the future.
This ensures that scripts like xcpretty can differentiate default output and error output.
115d3c6 to
1b1f03d
Compare
|
Check |
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two minor issues in the script as described in the commit messages.