[repo/push] --use-json to convert podspecs to JSON format when pushing #5568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me, think it's a good idea 👍 |
|
👍🏻 with a CHANGELOG entry |
|
Hey @maschall, there are a few rubocop errors, see https://travis-ci.org/CocoaPods/CocoaPods/jobs/140426614#L3353-L3356 — if you could fix them, we can merge 👍 You can use |
|
@neonichu thanks for the heads up and the steps to run locally |
|
Thanks @maschall ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈
We use a private repository for podspecs and found that when we changed to 1.0.1 cocoapods we had issues with Ruby DSLs that were old.
Following the trunk, we decided to convert our DSL to JSON format when pushing to our repository.
We thought that others could use the same thing.